-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Istio overlay for UI integration with Central Dashboard #595
Conversation
90f93f0
to
fc8c411
Compare
@Griffin-Sullivan please let me know when this is ready to test! |
5cc14ef
to
25deded
Compare
a3b6d98
to
9406ca9
Compare
beaf323
to
ca2fb83
Compare
// TODO: Readd GetNamespaceQueryParam once it's working | ||
const namespace = isStandalone() ? namespaceSelector?.name : 'kubeflow'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucferbux I made this change because getNamespaceQueryParam
was not working in Kubeflow. When it gets the window
the search url is not the same as what the dashboard has. We need to figure out a way to get the current namespace of the user.
ca2fb83
to
3ae2905
Compare
name?: string; | ||
}; | ||
|
||
export const mockNamespace = ({ name = 'kubeflow' }: MockNamespace): Namespace => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixing mock tests by adding the mock for Namespaces
Signed-off-by: Griffin-Sullivan <[email protected]>
3ae2905
to
6b51893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds all of the manifest changes and necessary frontend changes to integrate the Model Registry UI into the KF Central Dashboard. However, there are still some changes that you would need to add if you wanted to test this in your own KF deployment:
cluster-admin
cluster role bindingHow Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes