Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio overlay for UI integration with Central Dashboard #595

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Griffin-Sullivan
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan commented Nov 26, 2024

Description

This PR adds all of the manifest changes and necessary frontend changes to integrate the Model Registry UI into the KF Central Dashboard. However, there are still some changes that you would need to add if you wanted to test this in your own KF deployment:

  1. A NetworkPolicy for the UI and BFF similar to https://github.com/kubeflow/manifests/blob/master/common/networkpolicies/base/jupyter-web-app.yaml
  2. Editing the configmap for the central dashboard as described https://www.kubeflow.org/docs/components/central-dash/customize/#central-dashboard-configmap
  3. Deploying a Model Registry in the kubeflow namespace
  4. If you are not using upstream / unreleased MR then you will need to update the service annotations to include a displayName and description
  5. Giving your user / default user the cluster-admin cluster role binding

image

How Has This Been Tested?

  1. Deployed in Kubeflow
  2. Ran standalone locally (not in a cluster, which we should ideally do but would like someone else to try)

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@ederign
Copy link
Member

ederign commented Nov 27, 2024

@Griffin-Sullivan please let me know when this is ready to test!

@Griffin-Sullivan Griffin-Sullivan force-pushed the istio branch 4 times, most recently from 5cc14ef to 25deded Compare December 5, 2024 21:09
@Griffin-Sullivan Griffin-Sullivan force-pushed the istio branch 2 times, most recently from a3b6d98 to 9406ca9 Compare December 11, 2024 18:43
@Griffin-Sullivan Griffin-Sullivan force-pushed the istio branch 2 times, most recently from beaf323 to ca2fb83 Compare January 7, 2025 17:35
@Griffin-Sullivan Griffin-Sullivan marked this pull request as ready for review January 7, 2025 17:35
@google-oss-prow google-oss-prow bot requested a review from alexcreasy January 7, 2025 17:36
Comment on lines +8 to +9
// TODO: Readd GetNamespaceQueryParam once it's working
const namespace = isStandalone() ? namespaceSelector?.name : 'kubeflow';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucferbux I made this change because getNamespaceQueryParam was not working in Kubeflow. When it gets the window the search url is not the same as what the dashboard has. We need to figure out a way to get the current namespace of the user.

name?: string;
};

export const mockNamespace = ({ name = 'kubeflow' }: MockNamespace): Namespace => ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixing mock tests by adding the mock for Namespaces

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7c9c056 into kubeflow:main Jan 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants